Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dependency Test - max #1363

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

donyunardi
Copy link
Contributor

Fixes #1362

Increase iteration time to 1000 seconds by increasing sleep time

@donyunardi donyunardi linked an issue Oct 4, 2024 that may be closed by this pull request
@donyunardi donyunardi added the core label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            108      50  53.70%   107-114, 160-169, 171, 183-204, 229-232, 239-245, 248-249, 251
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             189      68  64.02%   24-52, 93, 187, 227-267
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 68       0  100.00%
R/module_nested_tabs.R              220      93  57.73%   40-144, 176, 201-203, 317, 356
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                152      11  92.76%   41-48, 84, 135-136, 174
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 216
R/module_transform_data.R            56      32  42.86%   17-51
R/modules.R                         181      32  82.32%   166-170, 225-228, 326-327, 359-373, 411, 423-431
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 43       0  100.00%
R/teal_data_utils.R                  32       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           203       0  100.00%
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3089    1261  59.18%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 75d76b7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Unit Tests Summary

  1 files   25 suites   8m 34s ⏱️
253 tests 249 ✅ 4 💤 0 ❌
508 runs  504 ✅ 4 💤 0 ❌

Results for commit 75d76b7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $63.99$ $-2.45$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💚 $37.82$ $-32.83$ $0$ $+6$ $0$ $0$
shinytest2-filter_panel 💚 $42.60$ $-42.54$ $-2$ $+3$ $0$ $0$
shinytest2-init 💚 $27.89$ $-27.84$ $-14$ $+3$ $0$ $0$
shinytest2-landing_popup 💚 $45.45$ $-45.38$ $-6$ $+5$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $35.84$ $-35.78$ $0$ $+4$ $0$ $0$
shinytest2-modules 💚 $39.23$ $-39.18$ $-1$ $+4$ $0$ $0$
shinytest2-reporter 💚 $68.26$ $-68.19$ $-3$ $+5$ $0$ $0$
shinytest2-show-rcode 💚 $10.65$ $-10.63$ $-6$ $+1$ $0$ $0$
shinytest2-teal_data_module 💚 $48.31$ $-48.23$ $-3$ $+6$ $0$ $0$
shinytest2-teal_slices 💚 $61.36$ $-61.33$ $-16$ $+2$ $0$ $0$
shinytest2-utils 💚 $10.72$ $-10.70$ $-3$ $+1$ $0$ $0$
shinytest2-wunder_bar 💚 $21.84$ $-21.81$ $-2$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_teal 💚 $19.25$ $-1.13$ creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended
shinytest2-data_summary 💚 $9.02$ $-9.01$ e2e_data_summary_displays_datasets_by_datanames_order_if_no_join_keys
shinytest2-data_summary 💚 $3.62$ $-3.61$ e2e_data_summary_displays_datasets_by_topological_sort_of_join_keys
shinytest2-data_summary 💚 $14.30$ $-9.35$ e2e_data_summary_is_displayed_properly_if_teal_data_include_data.frames_with_join_keys_MAE_objects_and_vectors
shinytest2-data_summary 💚 $3.40$ $-3.39$ e2e_data_summary_is_displayed_with_2_columns_data_without_keys
shinytest2-data_summary 💚 $3.60$ $-3.59$ e2e_data_summary_is_displayed_with_3_columns_for_data_with_join_keys
shinytest2-data_summary 💚 $3.88$ $-3.88$ e2e_data_summary_list_only_data_names_if_there_is_no_MAE_or_data.frames_in_teal_data
shinytest2-filter_panel 💚 $15.95$ $-15.93$ e2e_filtering_a_module_specific_filter_is_not_refected_in_other_unshared_modules
shinytest2-filter_panel 💚 $16.16$ $-16.15$ e2e_filtering_a_module_specific_filter_is_reflected_in_other_shared_module
shinytest2-filter_panel 💚 $10.48$ $-10.46$ e2e_module_content_is_updated_when_data_is_filtered_in_filter_panel
shinytest2-init 💚 $8.66$ $-8.65$ e2e_init_creates_UI_containing_specified_title_favicon_header_and_footer
shinytest2-init 💚 $8.58$ $-8.56$ e2e_teal_app_initializes_with_no_errors
shinytest2-init 💚 $10.65$ $-10.64$ e2e_teal_app_initializes_with_sessionInfo_modal
shinytest2-landing_popup 💚 $8.60$ $-8.58$ e2e_app_with_customized_landing_popup_module_creates_modal_containing_specified_title_content_and_buttons
shinytest2-landing_popup 💚 $8.58$ $-8.57$ e2e_app_with_default_landing_popup_module_creates_modal_containing_a_button
shinytest2-landing_popup 💚 $8.29$ $-8.27$ e2e_teal_app_with_landing_popup_module_initializes_with_no_errors
shinytest2-landing_popup 💚 $8.86$ $-8.85$ e2e_when_customized_button_in_landing_popup_module_is_clicked_it_redirects_to_a_certain_page
shinytest2-landing_popup 💚 $11.12$ $-11.11$ e2e_when_default_landing_popup_module_is_closed_it_shows_the_underlying_teal_app
shinytest2-module_bookmark_manager 💚 $8.37$ $-8.35$ bookmark_manager_button_is_not_rendered_by_default
shinytest2-module_bookmark_manager 💚 $8.38$ $-8.36$ bookmark_manager_button_is_not_rendered_when_enableBookmarking_url_
shinytest2-module_bookmark_manager 💚 $8.36$ $-8.35$ bookmark_manager_button_is_rendered_when_enableBookmarking_server_
shinytest2-module_bookmark_manager 💚 $10.73$ $-10.71$ bookmark_manager_button_shows_modal_with_url_containing_state_id_when_clicked
shinytest2-modules 💚 $8.75$ $-8.73$ e2e_all_the_nested_teal_modules_are_initiated_as_expected
shinytest2-modules 💚 $10.50$ $-10.49$ e2e_filter_panel_only_shows_the_data_supplied_using_datanames
shinytest2-modules 💚 $10.47$ $-10.45$ e2e_filter_panel_shows_all_the_datasets_when_datanames_is_all
shinytest2-modules 💚 $9.52$ $-9.50$ e2e_the_module_server_logic_is_only_triggered_when_the_teal_module_becomes_active
shinytest2-reporter 💚 $18.43$ $-18.41$ e2e_adding_a_report_card_in_a_module_adds_it_in_the_report_previewer_tab
shinytest2-reporter 💚 $19.03$ $-19.02$ e2e_reporter_does_not_show_the_secondary_column_that_shows_filter_panel
shinytest2-reporter 💚 $13.46$ $-13.45$ e2e_reporter_previewer_module_do_not_show_data_summary_nor_filter_panel
shinytest2-reporter 💚 $8.74$ $-8.73$ e2e_reporter_tab_is_created_when_a_module_has_reporter
shinytest2-reporter 💚 $8.59$ $-8.58$ e2e_reporter_tab_is_not_created_when_a_module_has_no_reporter
shinytest2-show-rcode 💚 $10.65$ $-10.63$ e2e_teal_app_initializes_with_Show_R_Code_modal
shinytest2-teal_data_module 💚 $8.37$ $-8.35$ e2e_teal_data_module_gets_removed_after_successful_data_load_when_once_TRUE
shinytest2-teal_data_module 💚 $11.80$ $-11.79$ e2e_teal_data_module_inputs_change_teal_data_object_that_is_passed_to_teal_main_UI
shinytest2-teal_data_module 💚 $7.74$ $-7.72$ e2e_teal_data_module_is_still_visible_after_successful_data_load_when_once_FALSE
shinytest2-teal_data_module 💚 $5.55$ $-5.54$ e2e_teal_data_module_shows_validation_errors
shinytest2-teal_data_module 💚 $9.13$ $-9.12$ e2e_teal_data_module_will_have_a_delayed_load_of_datasets
shinytest2-teal_data_module 💚 $5.72$ $-5.71$ e2e_teal_data_module_will_make_other_tabs_inactive_before_successful_data_load
shinytest2-teal_slices 💚 $23.69$ $-23.67$ e2e_teal_slices_filters_are_initialized_when_global_filters_are_created
shinytest2-teal_slices 💚 $37.67$ $-37.66$ e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created
shinytest2-utils 💚 $10.72$ $-10.70$ e2e_show_hide_hamburger_works_as_expected
shinytest2-wunder_bar 💚 $11.06$ $-11.04$ wunder_bar_srv_clicking_filter_icon_opens_filter_manager_modal
shinytest2-wunder_bar 💚 $10.78$ $-10.77$ wunder_bar_srv_clicking_snapshot_icon_opens_snapshot_manager_modal

Results for commit b7bac4f

♻️ This comment has been updated with latest results.

@donyunardi donyunardi marked this pull request as draft October 4, 2024 18:31
@donyunardi
Copy link
Contributor Author

Still fails:
https://github.com/insightsengineering/teal/actions/runs/11184035499/job/31093937769

One last time, update to 2000 seconds.

@donyunardi
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Test - max failed
1 participant