Skip to content

Commit

Permalink
add axis parameter to plot_grid() (#1155)
Browse files Browse the repository at this point in the history
follow-up on #1153

Integration test warns for chevron:
```
── Warning ('test-mng01.R:18:3'): mng01 works as expected with custom argument values ──
  Graphs cannot be vertically aligned unless the axis parameter is set. Placing graphs unaligned.
  Backtrace:
      ▆
   1. └─chevron::mng01_main(...) at test-mng01.R:18:3
   2.   └─base::lapply(...)
   3.     └─tern (local) FUN(X[[i]], ...)
   4.       └─cowplot::plot_grid(p, tbl, ncol = 1, align = "v")
   5.         └─cowplot::align_plots(...)
```

It might happen that snapshot test will fail. In such case please kindly
provide some help. I have re-run snapshots locally and I got differences
for unrelated graphs like KM Plots. This has to do with my local
settings. I might be unable to get same graphs like in CI.
  • Loading branch information
pawelru authored Dec 6, 2023
1 parent 11e9dc0 commit 20a84ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion R/g_lineplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ g_lineplot <- function(df,
}

# align plot and table
cowplot::plot_grid(p, tbl, ncol = 1, align = "v")
cowplot::plot_grid(p, tbl, ncol = 1, align = "v", axis = "tblr")
} else {
p
}
Expand Down

0 comments on commit 20a84ff

Please sign in to comment.