rework docs summarize_glm_count (#1269)

Fixes #1268

---------

Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Abinaya Yogasekaram <73252787+ayogasekaram@users.noreply.github.com>
Co-authored-by: b_falquet <64274616+BFalquet@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>

NAMESPACE

@@ -186,6 +186,7 @@ export(h_or_cat_interaction)
 export(h_or_cont_interaction)
 export(h_or_interaction)
 export(h_pkparam_sort)
+export(h_ppmeans)
 export(h_proportion_df)
 export(h_proportion_subgroups_df)
 export(h_row_counts)

NEWS.md

@@ -1,12 +1,18 @@
 # tern 0.9.5.9006
 ### Enhancements
 * Added `errorbar_width` and `linetype` parameters to `g_lineplot`.
+* Reworking of `summarize_glm_count()` documentation and all its associated functions to better describe the results and the functions' purpose.
 
 ### Bug Fixes
 * Fixed a bug in `a_surv_time` that threw an error when split only has `"is_event"`.
 * Added defaults for `d_count_cumulative` parameters as described in the documentation.
 * Empty levels on `g_lineplot` x-axis are not shown in either plots.
 * Fixed disappearing line in `g_lineplot` when using only one group or strata level.
+* Fixed defaults for formats and labels in `get_formats_from_stats` and `get_labels_from_stats`.
+* Fixed bug for linear scaling factor (`scale` parameter) being applied to response but not to rate in `h_glm_count` while all distributions have logarithmic link function.
+
+### Miscellaneous
+* Began deprecation of the confusing functions `summary_formats` and `summary_labels`.
 
 # tern 0.9.5
 

R/g_lineplot.R

@@ -157,8 +157,8 @@ g_lineplot <- function(df,
                        subtitle_add_paramcd = TRUE,
                        subtitle_add_unit = TRUE,
                        caption = NULL,
-                       table_format = get_formats_from_stats(table),
-                       table_labels = get_labels_from_stats(table),
+                       table_format = NULL,
+                       table_labels = NULL,
                        table_font_size = 3,
                        errorbar_width = 0.45,
                        newpage = lifecycle::deprecated(),
@@ -176,9 +176,16 @@ g_lineplot <- function(df,
   checkmate::assert_string(title, null.ok = TRUE)
   checkmate::assert_string(subtitle, null.ok = TRUE)
 
+  if (!is.null(table)) {
+    table_format <- get_formats_from_stats(table)
+    table_labels <- get_labels_from_stats(table)
+  }
+
   extra_args <- list(...)
-  if ("control" %in% names(extra_args) && all(table_labels == get_labels_from_stats(table))) {
-    table_labels <- table_labels %>% labels_use_control(extra_args[["control"]])
+  if ("control" %in% names(extra_args)) {
+    if (!is.null(table) && all(table_labels == get_labels_from_stats(table))) {
+      table_labels <- table_labels %>% labels_use_control(extra_args[["control"]])
+    }
   }
 
   if (is.character(interval)) {