Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Softer deprecation of create_afun_* #1033

Closed
Melkiades opened this issue Aug 17, 2023 · 0 comments · Fixed by #1034
Closed

Softer deprecation of create_afun_* #1033

Melkiades opened this issue Aug 17, 2023 · 0 comments · Fixed by #1034
Assignees
@Melkiades
Labels
automation bug Something isn't working sme

Comments

@Melkiades
Copy link
Contributor

No description provided.

@Melkiades Melkiades added bug Something isn't working sme automation labels Aug 17, 2023
@Melkiades Melkiades self-assigned this Aug 17, 2023
@edelarua edelarua mentioned this issue Aug 23, 2023
Merged
Melkiades added a commit that referenced this issue Aug 24, 2023
@Melkiades @github-actions
deprecate_warn instead of stop for create_afun* (#1034)
210d0aa 
Fixes #1033 

@BFalquet can I ask you to check if eventually this would work with your
old function?

Nevermind, added the tests from previous version with expect_warning

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Melkiades Melkiades

Labels
automation bug Something isn't working sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecate_warn instead of stop for create_afun* insightsengineering/tern
1 participant
@Melkiades