Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add biomarker-catalog to staged.deps to avoid downstream breaking changes #890

Closed
Melkiades opened this issue Apr 28, 2023 · 1 comment · Fixed by #895
Closed

Add biomarker-catalog to staged.deps to avoid downstream breaking changes #890

Melkiades opened this issue Apr 28, 2023 · 1 comment · Fixed by #895
Assignees
@Melkiades
Labels
automation sme

Comments

@Melkiades
Copy link
Contributor

ref: insightsengineering/biomarker-catalog#4

Apologies @danielinteractive for the breaking changes. They have been introduced to fix the table structure (#882).

I propose here to have biomarker-catalog as a downstream dependency for tern.
@danielinteractive
Copy link
Contributor

Thanks @Melkiades , that is a great idea, let's do that. Now with (most of) biomarker catalog becoming public on GH it will simplify things too

@Melkiades Melkiades mentioned this issue May 2, 2023
Merged
@Melkiades Melkiades self-assigned this May 2, 2023
Melkiades added a commit that referenced this issue May 3, 2023
@Melkiades
alphabetical order of staged.deps + biomarker-catalog (#895)
cc870fb 
Fixes #890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Melkiades Melkiades

Labels
automation sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

alphabetical order of staged.deps + biomarker-catalog insightsengineering/tern
2 participants
@danielinteractive @Melkiades