-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to poisson dist to see if it is the glm fit to be unstable #1059
Conversation
Code Coverage Summary
Diff against main
Results for commit: c5b321c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
.var = "AVAL", | ||
.df_row = anl, | ||
variables = list(arm = "ARMCD", offset = "lgTMATRSK", covariates = c("REGION1")), | ||
distribution = "quasipoisson" | ||
) | ||
|
||
testthat::expect_snapshot(fits2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not fail
@@ -87,7 +153,7 @@ | |||
[1] "Adjusted Rate" | |||
|
|||
$rate_ci | |||
[1] 1.983340 6.127155 | |||
[1] 3.047667 3.987387 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changed!! it is a simple seed problem imo
This is not a fix. We need tomorrow's integration tests to see if also the fit changes in the integration tests