-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add snaps for bland-altman function #1201
Conversation
Code Coverage Summary
Diff against main
Results for commit: 57bdafc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance DifferenceAdditional test case details
Results for commit 71bfa4b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use fixed numbers, avoid regenerating numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and updates, after https://github.com/insightsengineering/tern/pull/1200/files merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayogasekaram thanks for this! Just one note for me: we should skip graph testing on ci for now right? And also is it calling nestcolor? I think I forgot to enforce it when reviewing original PR
Unit Tests Summary 1 files 83 suites 1m 1s ⏱️ Results for commit 57bdafc. ♻️ This comment has been updated with latest results. |
@Melkiades great point. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @ayogasekaram
closes #1175