Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default format for mean p-values #1204

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Update default format for mean p-values #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Added `h_glm_negbin` to `h_glm_count` to enable count data analysis using a negative binomial model.
* Added argument `grade_groups_only` to `count_occurrences_by_grade` to allow users to only display rows for specified grade groups.

### Enhancements
* Default format for mean p-values (`mean_pval`) updated from `"xx.xx"` to `"x.xxxx | (<0.0001)"`.

### Bug Fixes
* Fixed nested column split label overlay issue in `rtable2gg` to clean up appearance of text labels.
* Fixed bug in `s_ancova` causing incorrect difference calculations for arm variables with irregular levels.
Expand Down
2 changes: 1 addition & 1 deletion R/utils_default_stats_formats_labels.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ tern_default_formats <- c(
mean_ci = "(xx.xx, xx.xx)",
mean_sei = "(xx.xx, xx.xx)",
mean_sdi = "(xx.xx, xx.xx)",
mean_pval = "xx.xx",
mean_pval = "x.xxxx | (<0.0001)",
median = "xx.x",
mad = "xx.x",
median_ci = "(xx.xx, xx.xx)",
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/_snaps/analyze_variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@
8 Mean 95% CI (-0.43, 0.69) 0 Mean 95% CI
9 Mean -/+ 1xSE (-0.11, 0.38) 0 Mean -/+ 1xSE
10 Mean -/+ 1xSD (-0.65, 0.91) 0 Mean -/+ 1xSD
11 Mean p-value (H0: mean = 0) 0.61 0 Mean p-value (H0: mean = 0)
11 Mean p-value (H0: mean = 0) 0.6052 0 Mean p-value (H0: mean = 0)
12 Median 0.3 0 Median
13 Median Absolute Deviation -0.0 0 Median Absolute Deviation
14 Median 95% CI (-0.82, 0.74) 0 Median 95% CI
Expand Down Expand Up @@ -1059,7 +1059,7 @@
8 Mean 95% CI (4.57, 5.69) 0 Mean 95% CI
9 Mean -/+ 1xSE (4.89, 5.38) 0 Mean -/+ 1xSE
10 Mean -/+ 1xSD (4.35, 5.91) 0 Mean -/+ 1xSD
11 Mean p-value (H0: mean = 0) 0.00 0 Mean p-value (H0: mean = 0)
11 Mean p-value (H0: mean = 0) <0.0001 0 Mean p-value (H0: mean = 0)
12 Median 5.3 0 Median
13 Median Absolute Deviation -0.0 0 Median Absolute Deviation
14 Median 95% CI (4.18, 5.74) 0 Median 95% CI
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/_snaps/utils_default_stats_formats_labels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
mean_se mean_ci mean_sei
"xx.x (xx.x)" "(xx.xx, xx.xx)" "(xx.xx, xx.xx)"
mean_sdi mean_pval median
"(xx.xx, xx.xx)" "xx.xx" "xx.x"
"(xx.xx, xx.xx)" "x.xxxx | (<0.0001)" "xx.x"
mad median_ci quantiles
"xx.x" "(xx.xx, xx.xx)" "xx.x - xx.x"
iqr range min
Expand Down Expand Up @@ -161,7 +161,7 @@
mean_se mean_ci mean_sei
"xx.x (xx.x)" "(xx.xx, xx.xx)" "(xx.xx, xx.xx)"
mean_sdi mean_pval median
"(xx.xx, xx.xx)" "xx.xx" "xx.x"
"(xx.xx, xx.xx)" "x.xxxx | (<0.0001)" "xx.x"
mad median_ci quantiles
"xx.x" "(xx.xx, xx.xx)" "xx.x - xx.x"
iqr range min
Expand Down
Loading