Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ungroup_stats() function #1385

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Jan 29, 2025

Pull Request

Fixes #1370

I also added in a fix for the currently failing integration test.

@edelarua edelarua added the sme label Jan 29, 2025
@edelarua edelarua enabled auto-merge (squash) January 29, 2025 16:03
@edelarua edelarua requested a review from Melkiades January 29, 2025 16:03
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Tests Summary

    1 files     84 suites   1m 16s ⏱️
  876 tests   867 ✅   9 💤 0 ❌
1 882 runs  1 185 ✅ 697 💤 0 ❌

Results for commit 66be144.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
analyze_vars_in_cols 💔 $2.48$ $+3.16$ $+17$ $-7$ $0$ $0$
count_occurrences 💔 $0.75$ $+1.63$ $+10$ $-8$ $0$ $0$
count_occurrences_by_grade 💔 $1.86$ $+1.02$ $+16$ $-17$ $0$ $0$
summarize_coxreg 💔 $3.91$ $+2.49$ $+13$ $-13$ $0$ $0$
summarize_num_patients 💔 $1.08$ $+1.31$ $+18$ $-16$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
analyze_vars_in_cols 💔 $0.52$ $+1.44$ summarize_works_with_nested_analyze
summarize_coxreg 💔 $0.65$ $+1.26$ summarize_coxreg_adds_the_multivariate_Cox_regression_layer_to_rtables

Results for commit 82ace48

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing integration tests too :) Good to go asis for me

@edelarua edelarua merged commit 2321c63 into main Jan 31, 2025
29 checks passed
@edelarua edelarua deleted the 1370_remove_ungroup_stats branch January 31, 2025 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to fix: ungroup_stats should be removed in favor of get_*_from_stats
2 participants