-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable .indent_mods
argument in all analysis functions
#945
Conversation
Code Coverage Summary
Diff against main
Results for commit: 7f1219e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks, Emily. Well done also with the deprecation! I would add just a couple of indentations in some of the tests. It should not be a problem in general, but indentation and wrapping caused many problems before, so we need to have it a bit more tested imo.
Closes #941
Indentation implemented in all functions except
tabulate_survival_subgroups
andtabulate_rsp_subgroups
.