Skip to content

Commit

Permalink
Remove support for json-schema in webpack.compat config
Browse files Browse the repository at this point in the history
Closes #227
  • Loading branch information
insin committed Jan 21, 2017
1 parent 65499a3 commit e6a13c3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 16 deletions.
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
**Removed:**

- Removed support for `json-schema` in `webpack.compat` config, as this library has now been fixed [[#227](https://github.com/insin/nwb/issues/227)]

**Dependencies:**

- karma: v1.3.0 → [v1.4.0](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md#140-2017-01-14)
Expand Down
11 changes: 0 additions & 11 deletions docs/Configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -328,16 +328,6 @@ The following libraries are supported:

Set to `true` for [Enzyme](http://airbnb.io/enzyme/) compatibility - this assumes you're using the latest version of React (v15).

###### `json-schema`: `Boolean`

Set to `true` to prevent a transitive [json-schema](https://github.com/kriszyp/json-schema) dependency from [breaking your Webpack build](https://github.com/kriszyp/json-schema/issues/59). Failure in this case manifests itself something like so:

```
Error: define cannot be used indirect
webpack:///(webpack)/buildin/amd-define.js
```

###### `moment`: `Object`

If you use [Moment.js](http://momentjs.com/) in a Webpack build, all the locales it supports will be imported by default and your build will be about 139KB larger than you were expecting!
Expand All @@ -357,7 +347,6 @@ module.exports = {
webpack: {
compat: {
enzyme: true,
'json-schema': true,
moment: {
locales: ['de', 'en-gb', 'es', 'fr', 'it']
},
Expand Down
5 changes: 0 additions & 5 deletions src/createWebpackConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,6 @@ export const COMPAT_CONFIGS = {
'react/lib/ReactContext': true,
}
},
'json-schema': {
module: {
noParse: [/node_modules[/\\]json-schema[/\\]lib[/\\]validate\.js/],
},
},
moment({locales}) {
return {
plugins: [
Expand Down

0 comments on commit e6a13c3

Please sign in to comment.