Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Classes in the React Template #216

Closed
ntwcklng opened this issue Dec 25, 2016 · 1 comment
Closed

Use Classes in the React Template #216

ntwcklng opened this issue Dec 25, 2016 · 1 comment
Labels

Comments

@ntwcklng
Copy link
Contributor

To match the Preact & Inferno Template, we should use Class x extends React.Component for creating a React Component instead of React.createClass({}).
In the near future React.createClass({}) will be replaced with Class x extends React.Component. See https://facebook.github.io/react/blog/2015/03/10/react-v0.13.html

@insin
Copy link
Owner

insin commented Jan 12, 2017

I think we should do this when/if we drop the react-transform Babel plugin in favour of the latest React Hot Loader, which AFAIK supports patching methods defined as class properties for binding.

@insin insin added the chore label Jan 12, 2017
insin added a commit that referenced this issue May 19, 2017
Avoids deprecation warnings in React >= 15.5

Closes #216
insin added a commit that referenced this issue May 19, 2017
Avoids deprecation warnings in React >= 15.5

Closes #216
@insin insin closed this as completed in 8d700e3 May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants