-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: disable CommonJS / ES5 / lib build #285
Comments
treshugart
added a commit
to treshugart/nwb
that referenced
this issue
Mar 24, 2017
treshugart
changed the title
Disable CommonJS / ES5 / lib build
Feature request: disable CommonJS / ES5 / lib build
Mar 24, 2017
Implemented in fork while awaiting PR: https://www.npmjs.com/package/@treshugart/nwb. |
insin
added a commit
that referenced
this issue
May 9, 2017
#285 - feat: allow CommonJS builds to disabled
Closing because PR was merged. Thank you! |
Thanks for the PRs, aiming to cut a release of whatever's in master on Thursday morning (AEST) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we only have a use case for using the UMD build. We want to disable building
lib
for a few reasons:es
/lib
a problem for consumers because they must know about the implementation details.main
to theumd
bundles to get around ^, therefore we don't want to incur the overhead ofes
/lib
at the moment.umd
in the future and only usees
/lib
but that requires a lot of work to get rid of the loaders.What I am proposing, in the form of a PR, is:
npm.cjs
option to be specified asfalse
to switch off the CommonJS buildThis means that even though it's a new feature, it's not a breaking change as the
lib
build will still be generated by default (opt-out).The text was updated successfully, but these errors were encountered: