Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject webpack assets instead of hardcoding them in the template #34

Closed
insin opened this issue Dec 27, 2015 · 2 comments
Closed

Inject webpack assets instead of hardcoding them in the template #34

insin opened this issue Dec 27, 2015 · 2 comments

Comments

@insin
Copy link
Owner

insin commented Dec 27, 2015

Investigate using inject: true to insert webpack assers before </body> - the current template hardcodes them, resulting in 404s for everything but app.js when running webpack on the server.

This should also preserve the correct ordering of dependencies, as html-webpack-plugin inserts entry assets last.

@insin insin changed the title Inject webpack assets into HTML instead of hardcoding them in the template Inject webpack assets instead of hardcoding them in the template Dec 27, 2015
@insin
Copy link
Owner Author

insin commented Jan 3, 2016

Defaulting to public/index.html allowed us to:

  1. Not have to decide where the HTML gets generated in, because it's static
  2. Make it easy for people to use static assets by putting them in the public/ directory

Guess we need to make some decisions now

@insin insin modified the milestone: 0.7 Jan 4, 2016
@insin insin modified the milestones: 0.7, 0.8 Jan 5, 2016
@insin
Copy link
Owner Author

insin commented Feb 26, 2016

inject is now enabled by default in html-webpack-plugin@2

@insin insin mentioned this issue Mar 3, 2016
Closed
8 tasks
insin added a commit that referenced this issue Mar 4, 2016
#66

As part of #38, handles using a cachebusting query param for static resources

Closes #34
@insin insin closed this as completed in 31e81d4 Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant