-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install missing dependencies (with --preact or --inferno flag) + Yarn support #214
Conversation
Use rimraf as a function, fixes #181 Includes a bit of refactoring to reduce duplicated spinner management
[ci skip]
When running the react-build command with —preact or —inferno
Maybe this PR is also a good place for #204? |
This probably is a good place to do that, then we can have a separate install function which handles choosing between nwb and yarn, and manages the spinner stuff etc, so the caller just has to provide a list of modules to be installed. |
Okay. |
|
fbed432
to
e46d1ba
Compare
@insin i see you already created a new install function, so this PR is needless. Is there anything else i can help you with? |
@ntwcklng apologies for digging a big hole under the work you did on this - I needed an install function which could check for resolvable dependencies while implementing I'm also almost done rewriting most of In places you find synchronous stuff or lots of copy and paste in nwb it's usually just me being lazy because I needed it to work now rather than having to deal with figuring things out properly, but I've finally been in the mood to fix things recently due to diving into Preact and Inferno. Let's see where the dust settles after v0.14. |
Okay, i will close this PR for now 👍 |
Related: #201