Fix bug that causes webpack.styles=false to fail.
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, thanks! |
|
I caught it 'cuz I tried using it, and it exploded. Didn't take long to find the cause, though. I would appreciate knowing when the fix is pushed into the npm registry, so that I can update my local builds to stop using my temporarily-hacked copy of nwb. |
insin
added a commit
that referenced
this pull request
May 30, 2017
|
@seanofw …now :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a type-testing bug in
getUserConfig.jsthat preventswebpack.stylesfrom being able to be set tofalse, like the documentation says it should be able to be. The previous if-condition correctly falls-through to the if-condition on line 495, which then incorrectly fails because the type doesn't matchobject.This pull request contains a simple one-line fix for the bug. Tested locally, and it works as expected. Cheers! :-)