Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where failure test didn't exists process with code 1 #36

Merged
merged 1 commit into from
Dec 31, 2015

Conversation

jihchi
Copy link
Contributor

@jihchi jihchi commented Dec 30, 2015

Environment & versions:

  • Mac OS X El Capitan
  • nwb 0.6.2
  • node v4.2.2

Screenshot:
screenshot_2015-12-30_23-36-38

Travis will always got pass...

@codecov-io
Copy link

Current coverage is 93.20%

Merging #36 into master will not affect coverage as of 8d70c8a

@@            master    #36   diff @@
=====================================
  Files           24     24       
  Stmts          427    427       
  Branches         0      0       
  Methods          0      0       
=====================================
  Hit            398    398       
  Partial          0      0       
  Missed          29     29       

Review entire Coverage Diff as of 8d70c8a

Powered by Codecov. Updated on successful CI builds.

@insin
Copy link
Owner

insin commented Dec 30, 2015

D'oh, dumb callback misuse on my part - will merge and release a fixed version this evening

Thanks for the PR, and especially for including a new test case

insin added a commit that referenced this pull request Dec 31, 2015
Fix an issue where failure test didn't exists process with code 1
@insin insin merged commit 55d1db2 into insin:master Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants