Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicPath cannot be null #432

Merged
merged 1 commit into from
Mar 8, 2018
Merged

publicPath cannot be null #432

merged 1 commit into from
Mar 8, 2018

Conversation

stephenwf
Copy link
Contributor

Webpack validation fails:

webpack.publicPath = 'type: null'
Must be a String

Webpack validation fails:
> webpack.publicPath = 'type: null'
>  Must be a String
@insin
Copy link
Owner

insin commented Mar 8, 2018

Webpack's own validation won't even allow publicPath to be null, so this is the right fix.

Thanks for the PR.

@insin insin merged commit dee288c into insin:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants