Adds Queue functionality to azurerm_storage_account #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2019 16:20
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
ghost
self-requested a review
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
ghost
added
the
Version: Bump Minor
ghost
commented
Oct 22, 2019
| @@ -84,14 +84,16 @@ def set_reader(name, value, override) | |||
| self | |||
| end | |||
|
|
|||
| def get(url:, api_version:, error_handler: nil, unwrap: nil, use_cache: true, params: {}) # rubocop:disable Metrics/ParameterLists | |||
| def get(url:, api_version:, error_handler: nil, unwrap: nil, use_cache: true, params: {}, headers: {}) # rubocop:disable Metrics/ParameterLists | |||
There was a problem hiding this comment.
Allow extending Clients to pass headers into their requests. Queue API defines version this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality to retrieve queue's for a given storage account.
Check List
rake lintpasses