Adds MySQL Resources #213
Merged
Adds MySQL Resources #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruairi Fennell <rfennell@chef.io>
Co-authored-by: Mikael Krief <krief_mikael@hotmail.com> Signed-off-by: Ruairi Fennell <rfennell@chef.io>
ghost
self-requested a review
ghost
mentioned this pull request
ghost
added
the
Version: Bump Minor
rmoles
reviewed
Oct 23, 2019
| ### Check MySQL Databases are present | ||
|
|
||
| describe azurerm_mysql_databases(resource_group: 'resource-group-1', server_name: 'production') do | ||
| it { should exist } |
There was a problem hiding this comment.
This probably isn't an issue with this PR, but I was wondering whether there is a need for exist in plural resources. I believe the same thing could be achieved through it { should_not be_empty }.
rmoles
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Resources, Documentation, TF and Tests/Controls for:
azurerm_mysql_serverazurerm_mysql_serversazurerm_mysql_databaseazurerm_mysql_databasesAlso housekeeping of TF & caching of some methods in
azurerm_sql_server&azurerm_sql_database.Issues Resolved
Adds some of the functionality proposed in #161 which has gone stale. I have credited https://github.com/mikaelkrief as co-author.
Check List
rake lintpasses