Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add have_encryption_enabled to azurerm_storage_account and type, location, tags to azurerm_storage_accounts #240

Merged
merged 7 commits into from
Apr 20, 2020

Conversation

rmoles
Copy link
Contributor

@rmoles rmoles commented Apr 17, 2020

Description

  • Add have_encryption_enabled to azurerm_storage_account and type, location, tags to azurerm_storage_accounts
  • use bundler to exec inspec in Rakefile Rakefile and use latest inspec in Gemfile
  • Add second tag to resource group
  • Update documentation

Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.

Issues Resolved

Fixes #232
Fixes #186
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Ross Moles added 4 commits April 17, 2020 17:54
…tion, tags to azurerm_storage_accounts

Signed-off-by: Ross Moles <rmoles@chef.io>
… in Gemfile

Signed-off-by: Ross Moles <rmoles@chef.io>
Signed-off-by: Ross Moles <rmoles@chef.io>
Signed-off-by: Ross Moles <rmoles@chef.io>
@rmoles rmoles requested a review from a team April 17, 2020 16:58
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @rmoles

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Apr 20, 2020
@skpaterson skpaterson merged commit e1d8bcd into master Apr 20, 2020
@chef-expeditor chef-expeditor bot deleted the storage_account_updates branch April 20, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants