Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor backend and generic resources to support wider range of resources #299

Merged
merged 6 commits into from
Sep 18, 2020
Merged

Refactor backend and generic resources to support wider range of resources #299

merged 6 commits into from
Sep 18, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

Updates in backend classes:

  • Support the resource_uri parameter to expand the scope of resources that can be tested.
  • resource_uri parameter will enable testing resources such as policy definition.
  • Improve resource-not-found filter.
  • Make less API calls for acquiring API versions.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Omer Demirok added 2 commits September 17, 2020 17:38
Add resource_uri parameter to support wider ranges of resources
5984056 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Remove redundant #collect_resources method
3ef950f 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner September 18, 2020 08:09
Fix a typo
8455b80 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Sep 18, 2020
@omerdemirok omerdemirok changed the title Resource uri param Refactor backend and generic resources to support wider range of resources Sep 18, 2020
rmoles
rmoles reviewed Sep 18, 2020
View reviewed changes
libraries/azure_backend.rb Outdated Show resolved Hide resolved
rmoles
rmoles reviewed Sep 18, 2020
View reviewed changes
libraries/azure_backend.rb Outdated Show resolved Hide resolved
Omer Demirok added 3 commits September 18, 2020 13:39
Update warning message
43d797b 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add resource_groups and policy_definitions
0c3fda0 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Revert "Add resource_groups and policy_definitions"
4520418 
This reverts commit 0c3fda0.
rmoles
rmoles approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerdemirok

@rmoles rmoles merged commit fd6a462 into master Sep 18, 2020
@rmoles rmoles deleted the resource_uri_param branch September 18, 2020 15:38
@tbugfinder tbugfinder mentioned this pull request Sep 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @rmoles