Enable users to define api versions for the additional property API calls #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
reviewed
Sep 22, 2020
libraries/azure_backend.rb
Outdated
| @@ -690,7 +688,7 @@ def respond_to_missing?(*several_variants) | |||
| end | |||
|
|
|||
| def to_s | |||
| "Property is missing! The following properties are available: #{item.keys.map(&:to_s)}" | |||
| "#{type}/#{name} has following properties: #{item.keys.map(&:to_s)}." | |||
There was a problem hiding this comment.
This should probably be: has the following
4 tasks
added 2 commits
September 22, 2020 17:34
Signed-off-by: Omer Demirok <odemirok@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omer Demirok odemirok@chef.io
Description
Users can provide a specific API version for the additional properties in the supported resources.
Issues Resolved
This will fix the failing CIS benchmark tests caused by incompatible API versions.
Check List
rake lintpasses