Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql_database(s) resources #308

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Add sql_database(s) resources #308

merged 2 commits into from
Sep 29, 2020

Conversation

omerdemirok
Copy link
Contributor

@omerdemirok omerdemirok commented Sep 28, 2020 •
edited
Loading

Signed-off-by: Omer Demirok odemirok@chef.io

Description

  • Add sql_database(s) resources
  • Update HTTP client headers to ensure receiving json type content
  • Improve parameter validator error message to show the not allowed parameters only

Issues Resolved

Fixes a failing control in Azure CIS Benchmarks

Check List

Add sql_database(s) resources
7ff8574 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner September 28, 2020 11:38
@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Sep 29, 2020
rmoles
rmoles approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerdemirok

@rmoles rmoles merged commit 7d594f8 into master Sep 29, 2020
@rmoles rmoles deleted the sql_database branch September 29, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @rmoles