Move credential checks into the AzureConnection#authenticate #314

omerdemirok · 2020-10-01T11:34:09Z

Signed-off-by: Omer Demirok odemirok@chef.io

Move credential checks into the AzureConnection#authenticate method to enable inspec check pass
Update Rakefile regarding the credential checks
Fix azure_resource_group#to_s method

Fixes #312

New functionality includes tests
All tests pass
rake lint passes
All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Signed-off-by: Omer Demirok <odemirok@chef.io>

libraries/backend/azure_connection.rb

Signed-off-by: Omer Demirok <odemirok@chef.io>

rmoles

Move credential checks into the AzureConnection#authenticate

855ff3a

Signed-off-by: Omer Demirok <odemirok@chef.io>

omerdemirok requested a review from a team as a code owner October 1, 2020 11:34

rmoles reviewed Oct 1, 2020

View reviewed changes

libraries/backend/azure_connection.rb Outdated Show resolved Hide resolved

Do not print credentials in the error message

d91e33c

Signed-off-by: Omer Demirok <odemirok@chef.io>

rmoles approved these changes Oct 1, 2020

View reviewed changes

rmoles merged commit 4cca730 into master Oct 1, 2020

rmoles deleted the credential_checks branch October 1, 2020 14:32

Provide feedback