Add management_group resources #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2020 11:49
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
Signed-off-by: Omer Demirok <odemirok@chef.io>
omerdemirok
added
the
Version: Bump Minor
omerdemirok
changed the title
added 2 commits
November 12, 2020 17:08
Signed-off-by: Omer Demirok <odemirok@chef.io>
omerdemirok
changed the title
rmoles
reviewed
Nov 17, 2020
rmoles
reviewed
Nov 17, 2020
| '$recurse' => opts[:recurse] || false, | ||
| } | ||
| opts[:query_parameters].merge!('$expand' => opts[:expand]) unless opts[:expand].nil? | ||
| # Note that $expand=children must be passed up if $recurse is set to true. |
There was a problem hiding this comment.
This code answers my question... I think the wording should be changed slightly. $expand=children must be set if $recurse is set to true.
OR
$expand=children will be set if $recurse is set to true.
There was a problem hiding this comment.
could this comment also be updated for consistency?
rmoles
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Thanks @omerdemirok great work as always. Just a small comment regarding wording.
Signed-off-by: Omer Demirok <odemirok@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Resolves #328
Check List
rake lintpasses