Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 2.5 from pipeline verification #341

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Remove 2.5 from pipeline verification #341

merged 1 commit into from
Nov 30, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok odemirok@chef.io

Description

Issues Resolved

Resolves #340

Check List

Remove 2.5 from pipiline verification
921e9dc 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner November 30, 2020 16:46
lhasadreams
lhasadreams approved these changes Nov 30, 2020
View reviewed changes
Copy link

@lhasadreams lhasadreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with that and they would be easy to add back should we decide to support V2.5 again, although it goes out of support in March 2021

@omerdemirok omerdemirok self-assigned this Nov 30, 2020
@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Nov 30, 2020
@omerdemirok omerdemirok merged commit 0f09ee2 into master Nov 30, 2020
@omerdemirok omerdemirok deleted the deprecate_2_5 branch November 30, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhasadreams lhasadreams lhasadreams approved these changes

Assignees

@omerdemirok omerdemirok

Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @lhasadreams