Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azure_network_watcher(s) resources #349

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Add azure_network_watcher(s) resources #349

merged 3 commits into from
Dec 4, 2020

Conversation

omerdemirok
Copy link
Contributor

Description

  • Add azure_network_watcher(s) resources

Issues Resolved

N/A

Check List

Omer Demirok added 2 commits December 4, 2020 12:26
Add azure_network_watcher resource(s)
3c415f8 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add legacy api version to the azurerm_network_watchers
e9fd163 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Dec 4, 2020
@omerdemirok omerdemirok requested a review from a team as a code owner December 4, 2020 12:31
@omerdemirok omerdemirok self-assigned this Dec 4, 2020
Fix rubocop issues
0387440 
Signed-off-by: Omer Demirok <odemirok@chef.io>
lhasadreams
lhasadreams approved these changes Dec 4, 2020
View reviewed changes
Copy link

@lhasadreams lhasadreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
All the test are in place and passing.

@omerdemirok omerdemirok merged commit b3bd008 into master Dec 4, 2020
@omerdemirok omerdemirok deleted the network_watcher branch December 4, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhasadreams lhasadreams lhasadreams approved these changes

Assignees

@omerdemirok omerdemirok

Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @lhasadreams