Support ad domain services #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
soumyo13
reviewed
Jul 22, 2021
| The control will pass if the filter returns at least one result. Use `should_not` if you expect zero matches. | ||
| ```ruby | ||
| describe azure_active_directory_domain_services do | ||
| it { should exist } |
There was a problem hiding this comment.
It should be "should_not"
soumyo13
reviewed
Jul 22, 2021
| | passwordNotificationWindowInDays | A list of password notification window days.| `passwordNotificationWindowInDays` | | ||
| | passwordValidityPeriodInDays | A list of password validity period in days. | `passwordValidityPeriodInDays` | | ||
| | supportedServices | A list of capabilities assigned to the domain. | `supportedServices` | | ||
| | state | A list of asynchronous operations scheduled. | `state` | |
There was a problem hiding this comment.
Why state is not pluralized?
There was a problem hiding this comment.
table schema that was auto-generated based on the response for domain services ..
sathish-progress
added
Documentation
Version: Bump Minor
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
IanMadd
approved these changes
Jul 27, 2021
…ad-domain-services
…ad-domain-services
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
ppradhan9
approved these changes
Aug 5, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support AD Domain Service(s)
Issues Resolved
#390
Check List
rake lintpasses