Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding 'virtual network peering' resource #421

Merged
merged 8 commits into from
Aug 17, 2021
Merged

adding 'virtual network peering' resource #421

merged 8 commits into from
Aug 17, 2021

Conversation

Rohit1509
Copy link

Signed-off-by: Rohit rohit.prasad.joshi@sap.com

Description

Adding 'virtual network peering' resource

Issues Resolved

None.

Check List

adding 'virtual network peering' resource
1b3be59 
Signed-off-by: Rohit <rohit.prasad.joshi@sap.com>
@Rohit1509 Rohit1509 requested a review from a team as a code owner July 30, 2021 02:37
@Rohit1509
Copy link
Author

Can you suggest on how can we remove those duplications in SonarCloud Cloud analysis ?

Thanks!

@sathish-progress
Copy link
Contributor

Can you suggest on how can we remove those duplications in SonarCloud Cloud analysis ?

Thanks!

let me try to validate that meanwhile could you check your build failures?

fixing rubocop error
0698de8 
Signed-off-by: Rohit <rohit.prasad.joshi@sap.com>
@Rohit1509
Copy link
Author

On it. Thanks!

@Rohit1509
Copy link
Author

@sathish-progress Build errors are fixed now.

@sathish-progress
Copy link
Contributor

Also please update readme

sathish-progress
sathish-progress requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes requested

Rohit added 2 commits August 5, 2021 08:21
removing legacy resource and updating 'readme'
8b3e6a7 
Signed-off-by: Rohit <rohit.prasad.joshi@sap.com>
Merge branch 'adding_virtual_network_peering_resource' of https://git…
39ca29d 
…hub.com/Rohit1509/inspec-azure into adding_virtual_network_peering_resource
@sathish-progress sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Aug 5, 2021
@sathish-progress sathish-progress self-requested a review August 5, 2021 17:08
sathish-progress
sathish-progress approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppradhan9 ppradhan9 requested a review from IanMadd August 9, 2021 06:21
@sathish-progress sathish-progress requested a review from a team August 16, 2021 09:41
kagarmoe
kagarmoe approved these changes Aug 16, 2021
View reviewed changes
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes

mindor docs changes
992f228 
Signed-off-by: Rohit <rohit.prasad.joshi@sap.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

@sathish-progress sathish-progress merged commit bb3b441 into inspec:master Aug 17, 2021
@lokeshk1987 lokeshk1987 linked an issue Sep 24, 2021 that may be closed by this pull request
Virtual network Peering - customer #493
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkumaras dkumaras dkumaras left review comments

@kagarmoe kagarmoe kagarmoe approved these changes

@sathish-progress sathish-progress sathish-progress approved these changes

@IanMadd IanMadd Awaiting requested review from IanMadd

Assignees
No one assigned
Labels
Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual network Peering - customer
5 participants
@Rohit1509 @sathish-progress @kagarmoe @dkumaras @ppradhan9