Support azure migrate assessments #424

sathish-progress · 2021-08-04T05:51:29Z

Description

Support singular and plural resource for Azure Migrate Assessment(s)

Also fixed #425 as part of this

Issues Resolved

#425

Check List

New functionality includes tests
All tests pass
rake lint passes
All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Signed-off-by: Sathish <sbabu@progress.com>

sa-progress

azureStorageRedundancy has other 4 types : GeoRedundant, ReadAccessGeoRedundant, Unknown, ZoneRedundant.
Shouldn't we provide this value as default value in variable.tf and other values like scalingFactor as well?

sathish-progress · 2021-08-05T14:38:52Z

azureStorageRedundancy has other 4 types : GeoRedundant, ReadAccessGeoRedundant, Unknown, ZoneRedundant.
Shouldn't we provide this value as default value in variable.tf and other values like scalingFactor as well?

sorry I didn't understand, this PR is about Azure Migrate Assessments and not about Azure Storage Redundancy ..

sa-progress

There are minor comments please check.

sa-progress · 2021-08-06T10:47:15Z

docs/resources/azure_migrate_assessment.md

+
+| Name           | Description                                                                      |
+|----------------|----------------------------------------------------------------------------------|
+| name           | Name of the Azure Migrate Assessments to test.                                   |


Name is twice .Please check once .

sa-progress · 2021-08-06T10:51:49Z

libraries/azure_migrate_assessment.rb

+    opts[:resource_path] = [opts[:project_name], 'groups', opts[:group_name], 'assessments'].join('/')
+    super(opts, true)
+  end
+end


to_s implementation is missing .

sa-progress · 2021-08-06T10:52:03Z

libraries/azure_migrate_assessments.rb

+      @table << resource.merge(resource[:properties])
+    end
+  end
+end


to_s implementation is missing .

…azure-migrate-assessments

Signed-off-by: Sathish <sbabu@progress.com>

…ure-migrate-assessments Signed-off-by: Sathish <sbabu@progress.com>

sa-progress

LGTM

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

IanMadd

Feedback for @dkumaras

IanMadd · 2021-09-09T18:06:32Z

docs/resources/azure_migrate_assessment.md

+
+## Syntax
+
+`name` is a required parameter, and `resource_group` is an optional parameter.


Line 52 shows four required parameters, not two.

this is done

IanMadd · 2021-09-09T18:21:07Z

docs/resources/azure_migrate_assessment.md

+`name` is a required parameter, and `resource_group` is an optional parameter.
+
+```ruby
+describe azure_migrate_assessment(resource_group: 'MIGRATED_VMS', project_name: 'ZONEA_MIGRATE_ASSESSMENT_PROJECT', group_name: 'ZONEA_MACHINES_GROUP', NAME: 'ZONEA_MACHINES_MIGRATE_ASSESSMENT') do


The placeholder values for the parameters should be more generic. So MIGRATED_VMS can just be RESOURCE_GROUP, ZONEA_MIGRATE_ASSESSMENT_PROJECT can just be PROJECT_NAME, ZONEA_MACHINES_GROUP can just be GROUP_NAME, and ZONEA_MACHINES_MIGRATE_ASSESSMENT should be MIGRATE_ASSESSMENT_NAME.

The same goes for the other code examples.

IanMadd · 2021-09-09T18:23:05Z

docs/resources/azure_migrate_assessment.md

+
+# azure_migrate_assessment
+
+Use the `azure_migrate_assessment` InSpec audit resource to test the properties related to Azure Migrate Assessments.


Assessment is a generic term so it should be lowercase. The same goes for all the other uses of "assessment". It's also singular "assessment" in this resource, but plural in the other resource.

IanMadd · 2021-09-09T18:24:00Z

docs/resources/azure_migrate_assessment.md

+
+The parameter set should be provided for a valid query:
+
+- `resource_group` and `project_name` and `group_name` and `name`


The ands can be replaced with commas.

IanMadd · 2021-09-09T18:27:50Z

docs/resources/azure_generic_resource.md

@@ -31,7 +31,7 @@ where

 The following parameters can be passed for targeting a specific Azure resource.

-| Name                                 | Description                                                                                              |
+| Name                                 |Description                                                       |


We don't need this change.

docs/resources/azure_migrate_assessment.md

docs/resources/azure_migrate_assessments.md

Signed-off-by: Sathish <sbabu@progress.com>

Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>

Signed-off-by: Sathish <sbabu@progress.com>

…ure-migrate-assessments

sathish-progress · 2021-09-16T02:46:59Z

@dkumaras , Could you please amend your signature to your commits that is causing the DCO to fail?

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

…e.md Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

…/inspec-azure into support-azure-migrate-assessments

…ure-migrate-assessments

sonarqubecloud · 2021-09-24T06:56:50Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sathish-progress added 6 commits August 4, 2021 08:53

support Bignum and Float for create method

4c7ca89

Signed-off-by: Sathish <sbabu@progress.com>

support azure migrate assessment(s)

e9a20a3

Signed-off-by: Sathish <sbabu@progress.com>

unit test azure migrate assessment(s)

74ae5d7

Signed-off-by: Sathish <sbabu@progress.com>

integrate test azure migrate assessment(s)

2bf1277

Signed-off-by: Sathish <sbabu@progress.com>

tf support outputs and variables

f1c0d4e

Signed-off-by: Sathish <sbabu@progress.com>

update docs for migrate assessment(s)

1a38568

Signed-off-by: Sathish <sbabu@progress.com>

sathish-progress requested a review from a team as a code owner August 4, 2021 05:51

sathish-progress linked an issue Aug 4, 2021 that may be closed by this pull request

dynamic resource methods with float values are being ignored #425

Closed

Merge branch 'master' into support-azure-migrate-assessments

8d17b24

sa-progress reviewed Aug 5, 2021

View reviewed changes

sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Aug 5, 2021

sa-progress reviewed Aug 6, 2021

View reviewed changes

sathish-progress added 5 commits August 19, 2021 13:43

Merge branch 'master' of github.com:inspec/inspec-azure into support-…

527df9e

…azure-migrate-assessments

fix azure tf

1363fbf

Signed-off-by: Sathish <sbabu@progress.com>

implement to_s

5ab1e61

Signed-off-by: Sathish <sbabu@progress.com>

use populate tabel from response

40c81f8

Signed-off-by: Sathish <sbabu@progress.com>

update docs

892221b

Signed-off-by: Sathish <sbabu@progress.com>

sathish-progress requested a review from a team as a code owner August 19, 2021 08:16

sathish-progress requested a review from sa-progress August 19, 2021 08:17

sathish-progress added 2 commits August 31, 2021 18:15

Merge branch 'main' into support-azure-migrate-assessments

78ce9e7

Merge branch 'main' of github.com:inspec/inspec-azure into support-az…

6032a80

…ure-migrate-assessments Signed-off-by: Sathish <sbabu@progress.com>

sa-progress approved these changes Aug 31, 2021

View reviewed changes

edits

1f6adf5

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

IanMadd reviewed Sep 9, 2021

View reviewed changes

sathish-progress and others added 4 commits September 13, 2021 11:25

fix required params doc

ee421e1

Signed-off-by: Sathish <sbabu@progress.com>

Update docs/resources/azure_migrate_assessment.md

d14856f

Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>

Update docs/resources/azure_migrate_assessment.md

a267ecd

Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>

Update docs/resources/azure_migrate_assessments.md

d27c5b6

Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>

sathish-progress and others added 5 commits September 13, 2021 11:27

Update docs/resources/azure_migrate_assessments.md

c78f077

Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>

fix docs link

04cec98

Signed-off-by: Sathish <sbabu@progress.com>

Ian's comments

74e8f7b

title case changes

e523c42

Merge branch 'main' of github.com:inspec/inspec-azure into support-az…

ad22f46

…ure-migrate-assessments

dkumaras added 4 commits September 17, 2021 12:28

removing changes to azure_migrate_project_database.md file

e80007a

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

removed unwanted changes from project db file

7a963a0

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

removing changes made to docs/resources/azure_migrate_project_databas…

a600d5d

…e.md Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

user defined name changes

81f2d51

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

IanMadd approved these changes Sep 22, 2021

View reviewed changes

sathish-progress and others added 3 commits September 23, 2021 21:36

Merge branch 'support-azure-migrate-assessments' of github.com:inspec…

184013c

…/inspec-azure into support-azure-migrate-assessments

Merge branch 'main' of github.com:inspec/inspec-azure into support-az…

efd0214

…ure-migrate-assessments

Merge branch 'main' into support-azure-migrate-assessments

d827add

sathish-progress merged commit b6dbffa into main Sep 24, 2021

sathish-progress deleted the support-azure-migrate-assessments branch September 24, 2021 07:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support azure migrate assessments #424

Support azure migrate assessments #424

sathish-progress commented Aug 4, 2021 •

edited

Loading

sa-progress left a comment

sathish-progress commented Aug 5, 2021

sa-progress left a comment

sa-progress Aug 6, 2021

sa-progress Aug 6, 2021

sathish-progress Aug 31, 2021

sa-progress Aug 6, 2021

sathish-progress Aug 31, 2021

sa-progress left a comment

IanMadd left a comment

IanMadd Sep 9, 2021

sathish-progress Sep 13, 2021

IanMadd Sep 9, 2021

IanMadd Sep 9, 2021

IanMadd Sep 9, 2021

IanMadd Sep 9, 2021

sathish-progress commented Sep 16, 2021

sonarqubecloud bot commented Sep 24, 2021


		## Syntax

		`name` is a required parameter, and `resource_group` is an optional parameter.


		# azure_migrate_assessment

		Use the `azure_migrate_assessment` InSpec audit resource to test the properties related to Azure Migrate Assessments.


		The parameter set should be provided for a valid query:

		- `resource_group` and `project_name` and `group_name` and `name`

Support azure migrate assessments #424

Support azure migrate assessments #424

Conversation

sathish-progress commented Aug 4, 2021 • edited Loading

Description

Issues Resolved

Check List

sa-progress left a comment

Choose a reason for hiding this comment

sathish-progress commented Aug 5, 2021

sa-progress left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sa-progress left a comment

Choose a reason for hiding this comment

IanMadd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sathish-progress commented Sep 16, 2021

sonarqubecloud bot commented Sep 24, 2021

sathish-progress commented Aug 4, 2021 •

edited

Loading