-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESOURCE-135 F/alert rule #477
Conversation
Signed-off-by: sa-progress <samir.anand@progress.com>
…alert_rule Signed-off-by: sa-progress <samir.anand@progress.com>
…alert_rule Signed-off-by: sa-progress <samir.anand@progress.com>
Hey @sa-progress , I guess this is the terraform for sentinel alert rule.. Could you check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please change the content of the singular resource? |
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
|
||
## Syntax | ||
|
||
An `azure_sentinel_alert_rule` resource block returns all Azure alert_rule, either within a Resource Group (if provided), or within an entire Subscription. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the resource group required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is required!
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
✅ Deploy Preview for inspec-azure ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Samir - Pls check the changes and revert. There are some doubts, Ill talk to you tomorrow
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
rake lint
passes