Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOURCE-135 F/alert rule #477

Merged
merged 23 commits into from
Jun 1, 2022
Merged

RESOURCE-135 F/alert rule #477

merged 23 commits into from
Jun 1, 2022

Conversation

sa-progress
Copy link
Contributor

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

@sa-progress sa-progress linked an issue Sep 28, 2021 that may be closed by this pull request
@sa-progress sa-progress self-assigned this Sep 28, 2021
@sathish-progress
Copy link
Contributor

Hey @sa-progress , I guess this is the terraform for sentinel alert rule.. Could you check this?
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/sentinel_alert_rule_scheduled

Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: sa-progress <samir.anand@progress.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@clintoncwolfe clintoncwolfe changed the title F/alert rule RESOURCE-135 F/alert rule Feb 17, 2022
@soumyo13
Copy link
Contributor

Please change the content of the singular resource?

Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested a review from IanMadd March 2, 2022 11:43

## Syntax

An `azure_sentinel_alert_rule` resource block returns all Azure alert_rule, either within a Resource Group (if provided), or within an entire Subscription.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the resource group required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is required!

Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@netlify
Copy link

netlify bot commented May 31, 2022

Deploy Preview for inspec-azure ready!

Name Link
🔨 Latest commit 7cf2541
🔍 Latest deploy log https://app.netlify.com/sites/inspec-azure/deploys/6296081c4904bb0009470965
😎 Deploy Preview https://deploy-preview-477--inspec-azure.netlify.app/inspec/resources/azure_sentinel_alert_rule
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@dkumaras dkumaras requested review from dkumaras and removed request for IanMadd May 31, 2022 12:21
Copy link
Contributor

@dkumaras dkumaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samir - Pls check the changes and revert. There are some doubts, Ill talk to you tomorrow

@clintoncwolfe clintoncwolfe merged commit 9c88d1e into main Jun 1, 2022
@clintoncwolfe clintoncwolfe deleted the f/alert_rule branch June 1, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Sentinal Alert Rule
9 participants