Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOURCE-157 Support power bi embedded capacities #487

Merged
merged 11 commits into from
Mar 12, 2022

Conversation

sathish-progress
Copy link
Contributor

Description

Support Power BI embedded capacities

Issues Resolved

#454

Check List

Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress sathish-progress requested review from a team as code owners September 23, 2021 16:04
@sathish-progress sathish-progress linked an issue Sep 23, 2021 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sathish-progress sathish-progress added Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Sep 28, 2021
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


```ruby
describe azure_power_bi_embedded_capacity(resource_group: 'RESOURCE_GROUP', name: 'POWER_BI_EMBEDDED') do
its() { should eq 1.0 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

Suggested change
its() { should eq 1.0 }
its('count') { should eq 1 }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the changes.

Comment on lines 34 to 41
| Name | Description |
|----------------|----------------------------------------------------------------------------------|
| account_name | The Azure Storage account name. |
| dns_suffix | The DNS suffix for the Azure Data Lake Storage endpoint. |

The parameter set should be provided for a valid query:
- `account_name`
- `account_name` and `dns_suffix` (optional)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these aren't even optional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parameters are optional. We have made the required changes. Please check.

@clintoncwolfe clintoncwolfe changed the title Support power bi embedded capacities RESOURCE-157 Support power bi embedded capacities Feb 17, 2022
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested a review from IanMadd March 2, 2022 11:14
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 merged commit f943a86 into main Mar 12, 2022
@soumyo13 soumyo13 deleted the support-power-bi-embedded-capacities branch March 12, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation ReadyForDocs Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power BI Embedded
6 participants