Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support caching of azure nw sgs #624

Merged
merged 9 commits into from
Feb 1, 2022
Merged

Support caching of azure nw sgs #624

merged 9 commits into from
Feb 1, 2022

Conversation

sathish-progress
Copy link
Contributor

Description

Issues Resolved

#623

Check List

@sathish-progress
allow resource data params
a94d920 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
skip length verifications for resource data
5bb3fd7 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
render get resource with resource data attributes
216e8ef 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress sathish-progress requested a review from a team as a code owner January 21, 2022 05:56
@sathish-progress
populate filter table from response for nsgs
38db49b 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
update docs for nsgs
4cc2933 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress sathish-progress requested a review from a team as a code owner January 24, 2022 05:43
@sathish-progress
add resource data to query params
8b3cfb4 
Signed-off-by: Sathish <sbabu@progress.com>
@sathish-progress
doc min required role
9a44fe7 
Signed-off-by: Sathish <sbabu@progress.com>
sa-progress
sa-progress approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sathish-progress sathish-progress added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Jan 27, 2022
@IanMadd IanMadd self-requested a review January 28, 2022 18:59
@IanMadd
Docs edits
c4e0225 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@IanMadd IanMadd force-pushed the support-azure-nw-sgs branch from efca6c7 to c4e0225 Compare January 31, 2022 23:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sathish-progress sathish-progress merged commit 8d5fca8 into main Feb 1, 2022
@sathish-progress sathish-progress deleted the support-azure-nw-sgs branch February 1, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-progress sa-progress sa-progress approved these changes

@IanMadd IanMadd IanMadd approved these changes

Assignees
No one assigned
Labels
CFT Support Documentation ReadyForDocs Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sathish-progress @IanMadd @sa-progress @ppradhan9