Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESOURCE-505 Soumyo/azure blob service #674

Merged
merged 11 commits into from
Nov 14, 2022
Merged

RESOURCE-505 Soumyo/azure blob service #674

merged 11 commits into from
Nov 14, 2022

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Sep 19, 2022 •
edited
Loading

Signed-off-by: Soumyodeep Karmakar soumyo.k13@gmail.com

Description

  1. It contains all the singular and plural resources.
  2. Added the resource_id in the singular resource.
  3. Modified the docs according to the new format.

This resource is a requirement.

Issues Resolved

NA

Check List

Please fill a box or appropriate ([x]) or mark N/A.

@soumyo13
added the missing outputs
604ed17 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added singular resource
421dca0 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added plural resource
b43c12d 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added singular integration test
4e94743 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added plural integration test
9ce2806 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added singular unit test
f81cedb 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added plural unit test
42ef687 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested a review from a team as a code owner September 19, 2022 10:45
@soumyo13 soumyo13 self-assigned this Sep 19, 2022
@netlify
Copy link

netlify bot commented Sep 19, 2022 •
edited
Loading

✅ Deploy Preview for inspec-azure ready!

Name Link
🔨 Latest commit bf36666
🔍 Latest deploy log https://app.netlify.com/sites/inspec-azure/deploys/636bf3883a34120009d19629
😎 Deploy Preview https://deploy-preview-674--inspec-azure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@soumyo13 soumyo13 changed the title Soumyo/azure blob service RESOURCE-505 Soumyo/azure blob service Sep 20, 2022
sa-progress
sa-progress approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyo13
adding the singular docs
5c61941 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
adding the plural docs
4f7b84f 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
tests modified
9c7ad17 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@IanMadd
Docs edits
bf36666 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@clintoncwolfe clintoncwolfe merged commit 8a25882 into main Nov 14, 2022
@clintoncwolfe clintoncwolfe deleted the soumyo/azure_blob_service branch November 14, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-progress sa-progress sa-progress approved these changes

@IanMadd IanMadd IanMadd approved these changes

Assignees

@soumyo13 soumyo13

Labels
azure Documentation Feature Request Request for a new feature ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumyo13 @IanMadd @sa-progress @clintoncwolfe