Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESOURCE-547 Switch inspec-azure to chefstyle #705

Merged
merged 7 commits into from
Dec 16, 2022
Merged

RESOURCE-547 Switch inspec-azure to chefstyle #705

merged 7 commits into from
Dec 16, 2022

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Dec 14, 2022 •
edited
Loading

Description

We are now running the rake lint with chefstyle.

Issues Resolved

Previously we were using rubocop to check the lint errors. Now we will be using the chefstyle.

Check List

@soumyo13
adding the chefstyle
f33437e 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
adding the required gems
b1e451d 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
fixing the lint errors
8b65bfb 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
fixing the lint in libraries
6cea238 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
fixing the lint in lib
53b5893 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested a review from a team as a code owner December 14, 2022 08:08
@soumyo13 soumyo13 self-assigned this Dec 14, 2022
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for inspec-azure canceled.

Name Link
🔨 Latest commit c185b62
🔍 Latest deploy log https://app.netlify.com/sites/inspec-azure/deploys/639986272b1cbe0008a95aff

@soumyo13
fixing the lint in Rubocop
92547af 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
fixing the lint in Gemfile
c185b62 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 changed the title RESOURCE-547 Switch inspec-aws to chefstyle RESOURCE-547 Switch inspec-aws to chefstyle [WIP] Dec 14, 2022
sa-progress
sa-progress approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@sa-progress sa-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@soumyo13 soumyo13 changed the title RESOURCE-547 Switch inspec-aws to chefstyle [WIP] RESOURCE-547 Switch inspec-azure to chefstyle Dec 16, 2022
@soumyo13 soumyo13 merged commit 46ff23d into main Dec 16, 2022
@soumyo13 soumyo13 deleted the RESOURCE-547-switch-inspec-azure-to-chefstyle branch December 16, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-progress sa-progress sa-progress approved these changes

Assignees

@soumyo13 soumyo13

Labels
azure enhancement tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumyo13 @sa-progress