Add hard disable for cache option and remove all cache from debug shell.

Signed-off-by: Jared Quick <jquick@chef.io>

lib/inspec/backend.rb

@@ -40,7 +40,7 @@ def inspect
     #
     # @param [Hash] config for the transport backend
     # @return [TransportBackend] enriched transport instance
-    def self.create(config)
+    def self.create(config) # rubocop:disable Metrics/AbcSize
       conf = Train.target_config(config)
       name = Train.validate_backend(conf)
       transport = Train.create(name, conf)
@@ -53,19 +53,20 @@ def self.create(config)
         raise "Can't connect to transport backend '#{name}'."
       end
 
+      # set caching settings
+      if config[:backend_cache]
+        connection.enable_cache(:command)
+      elsif config[:debug_shell]
+        connection.disable_cache(:file)
+        connection.disable_cache(:command)
+      elsif !config[:backend_cache] && config[:backend] != :mock
+        connection.disable_cache(:command)
+      end
+
       cls = Class.new do
-        attr_accessor :cache_resources
         include Base
 
-        def initialize
-          @cache_resources = false
-        end
-
         define_method :backend do
-          if @cache_resources
-            connection.enable_cache(:file)
-            connection.enable_cache(:command)
-          end
           connection
         end
 

lib/inspec/base_cli.rb

@@ -15,8 +15,6 @@ def self.target_options
         desc: 'Choose a backend: local, ssh, winrm, docker.'
       option :host, type: :string,
         desc: 'Specify a remote host which is tested.'
-      option :backend_cache, type: :boolean, default: false,
-        desc: 'Allow caching for backend file and command calls.'
       option :port, aliases: :p, type: :numeric,
         desc: 'Specify the login port for a remote scan.'
       option :user, type: :string,
@@ -69,6 +67,8 @@ def self.exec_options
         desc: 'Use the given path for caching dependencies. (default: ~/.inspec/cache)'
       option :create_lockfile, type: :boolean, default: true,
         desc: 'Write out a lockfile based on this execution (unless one already exists)'
+      option :backend_cache, type: :boolean, default: false,
+        desc: 'Allow caching for backend command output.'
     end
 
     private

lib/inspec/cli.rb

@@ -190,6 +190,7 @@ def detect
   def shell_func
     diagnose
     o = opts.dup
+    o[:debug_shell] = true
 
     json_output = ['json', 'json-min'].include?(opts['format'])
     log_device = json_output ? nil : STDOUT

lib/inspec/runner.rb

@@ -53,9 +53,6 @@ def initialize(conf = {})
 
       load_attributes(@conf)
       configure_transport
-
-      # set caching on backend
-      @backend.cache_resources = @conf[:backend_cache] || false
     end
 
     def tests

test/functional/inspec_shell_test.rb

@@ -14,6 +14,16 @@ def do_shell_c(code, exit_status, json = false, stderr = '')
       out
     end
 
+    it 'confirm file caching is disabled' do
+      out = do_shell_c('inspec.backend.cache_enabled?(:file)', 0)
+      out.stdout.chop.must_equal 'false'
+    end
+
+    it 'confirm command caching is disabled' do
+      out = do_shell_c('inspec.backend.cache_enabled?(:command)', 0)
+      out.stdout.chop.must_equal 'false'
+    end
+
     it 'can run ruby expressions (json output)' do
       x = rand
       y = rand

test/unit/runner_test.rb

@@ -16,7 +16,7 @@
         opts = { backend_cache: true }
         runner = Inspec::Runner.new(opts)
         backend = runner.instance_variable_get(:@backend)
-        backend.cache_resources.must_equal true
+        backend.backend.cache_enabled?(:command).must_equal true
       end
     end
 
@@ -25,12 +25,12 @@
         opts = { backend_cache: false }
         runner = Inspec::Runner.new(opts)
         backend = runner.instance_variable_get(:@backend)
-        backend.cache_resources.must_equal false
+        backend.backend.cache_enabled?(:command).must_equal false
       end
 
       it 'returns a backend without caching as default' do
         backend = runner.instance_variable_get(:@backend)
-        backend.cache_resources.must_equal false
+        backend.backend.cache_enabled?(:command).must_equal false
       end
     end