Use named pipe to decrease local Windows runtime

test/unit/transports/local_test.rb

@@ -6,10 +6,11 @@
 class TransportHelper
   attr_accessor :transport
 
-  def initialize
+  def initialize(type = :mock)
     Train::Platforms::Detect::Specifications::OS.load
-    plat = Train::Platforms.name('mock').in_family('linux')
+    plat = Train::Platforms.name('mock')
     plat.add_platform_methods
+    plat.stubs(:windows?).returns(true) if type == :windows
     Train::Platforms::Detect.stubs(:scan).returns(plat)
     @transport = Train::Transports::Local.new
   end
@@ -93,4 +94,36 @@ def mock_run_cmd(cmd, &block)
       end
     end
   end
+
+  describe 'when running on Windows' do
+    let(:connection) { TransportHelper.new(:windows).transport.connection }
+
+    let(:runner) { mock }
+
+    it 'uses `WindowsPipeRunner` by default' do
+      Train::Transports::Local::Connection::WindowsPipeRunner
+        .expects(:new)
+        .returns(runner)
+
+      Train::Transports::Local::Connection::WindowsShellRunner
+        .expects(:new)
+        .never
+
+      runner.expects(:run_command).with('not actually executed')
+      connection.run_command('not actually executed')
+    end
+
+    it 'uses `WindowsShellRunner` when a named pipe is not available' do
+      Train::Transports::Local::Connection::WindowsPipeRunner
+        .expects(:new)
+        .raises(Train::Transports::Local::PipeError)
+
+      Train::Transports::Local::Connection::WindowsShellRunner
+        .expects(:new)
+        .returns(runner)
+
+      runner.expects(:run_command).with('not actually executed')
+      connection.run_command('not actually executed')
+    end
+  end
 end

test/windows/local_test.rb

@@ -43,31 +43,36 @@
     cmd.stderr.must_equal ''
   end
 
-  # Verify pipe is created by using PowerShell to check pipe location. This
-  # works by intercepting the `SecureRandom` call which controls the pipe
-  # name. If this command uses a pipe, then the `stdout` of this command will
-  # contain the pipe name.
   it 'can execute a command using a named pipe' do
-    SecureRandom.expects(:hex).returns('with_pipe')
+    SecureRandom.expects(:hex).returns('via_pipe')
 
-    cmd = conn.run_command('Get-ChildItem //./pipe/ | Where-Object { $_.Name -Match "inspec_with_pipe" }')
-    cmd.stdout.must_match /inspec_with_pipe/
+    Train::Transports::Local::Connection::WindowsShellRunner
+      .any_instance
+      .expects(:new)
+      .never
+
+    cmd = conn.run_command('Write-Output "Create pipe"')
+    File.exist?('//./pipe/inspec_via_pipe').must_equal true
+    cmd.stdout.must_equal "Create pipe\r\n"
     cmd.stderr.must_equal ''
   end
 
-  it 'when named pipe is not available it uses `WindowsShellRunner`' do
-    # Prevent named pipe from being created
+  it 'can execute a command via ShellRunner if pipe creation fails' do
+    # By forcing `acquire_pipe` to fail to return a pipe, any attempts to create
+    # a `WindowsPipeRunner` object should fail. If we can still run a command,
+    # then we know that it was successfully executed by `Mixlib::ShellOut`.
     Train::Transports::Local::Connection::WindowsPipeRunner
       .any_instance
       .expects(:acquire_pipe)
+      .at_least_once
       .returns(nil)
 
-    Train::Transports::Local::Connection::WindowsShellRunner
-      .any_instance
-      .expects(:run_command)
+    proc { Train::Transports::Local::Connection::WindowsPipeRunner.new }
+      .must_raise(Train::Transports::Local::PipeError)
 
-    # Run command to trigger our stubs/expects
-    conn.run_command('Write-Host "using ShellOut"')
+    cmd = conn.run_command('Write-Output "test"')
+    cmd.stdout.must_equal "test\r\n"
+    cmd.stderr.must_equal ''
   end
 
   describe 'file' do