Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debugging experience by making platform and connection less noisy. #565

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Improve debugging experience by making platform and connection less noisy. #565

merged 4 commits into from
Feb 3, 2020

Conversation

zenspider
Copy link
Contributor

This is a big pet peeve while debugging resources in inspec. Lots of
noise, zero insight. This provides exactly the info we need for
connections and platforms.

Signed-off-by: Ryan Davis zenspider@chef.io

@zenspider
Added friendly #to_s and #inspect to Platforms::Common and BaseConnec…
0b86a89 
…tion.

This is a big pet peeve while debugging resources in inspec. Lots of
noise, zero insight. This provides exactly the info we need for
connections and platforms.

Signed-off-by: Ryan Davis <zenspider@chef.io>
@zenspider
Clean up tests.
9e7f044 
1. There is zero need to meta-program in our tests, so no Class.new
unless there is a good reason.
2. We don't need to create a new connection each time (VERY HEAVY) for
simple unit tests.

This drops full test runs down to < 1s.

Signed-off-by: Ryan Davis <zenspider@chef.io>
@zenspider zenspider requested a review from a team as a code owner January 30, 2020 20:37
@chef-expeditor
Copy link
Contributor

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@zenspider zenspider changed the title Added friendly #to_s and #inspect to Platforms::Common and BaseConnection. Improve debugging experience by making platform and connection less noisy. Jan 30, 2020
@zenspider
Exclude team members from PR template
b5b1664 
Signed-off-by: Ryan Davis <zenspider@chef.io>
@zenspider
More yamllint fixes.
41b0aa1 
Whitespace only

Signed-off-by: Ryan Davis <zenspider@chef.io>
@codeclimate
Copy link

codeclimate bot commented Jan 30, 2020

Code Climate has analyzed commit 41b0aa1 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 7

View more on Code Climate.

@zenspider zenspider merged commit 4f42b09 into master Feb 3, 2020
@chef-expeditor chef-expeditor bot deleted the zenspider/inspect branch February 3, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@clintoncwolfe clintoncwolfe Awaiting requested review from clintoncwolfe

Assignees

@zenspider zenspider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenspider @miah