Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Maps and Sets #54

Closed
mattiasholmlund opened this issue Jan 31, 2018 · 2 comments
Closed

Compare Maps and Sets #54

mattiasholmlund opened this issue Jan 31, 2018 · 2 comments

Comments

@mattiasholmlund
Copy link

@substack wrote in tape-testing/tape#342:

Once this is merged into core I will release a new major version of deep-equal based on the new algorithm that tape can be updated to support.

As far as I can see, node 8 has a deepEqual that can properly compare Maps and Sets:

node-v8.9.4-linux-x64 $ ./bin/node
> const assert = require('assert')
undefined
> assert.deepEqual(new Set('a'), new Set('a'))
undefined
> assert.deepEqual(new Set('a'), new Set('b'))
AssertionError [ERR_ASSERTION]: Set { 'a' } deepEqual Set { 'b' }
>

I find Sets and Maps very useful and want to use them with t.deepEqual() in tape.

@kumavis
Copy link

kumavis commented Aug 30, 2019

+1 to this feature, and seeing it get into tape

@simoelmou
Copy link

+1 to this feature

ljharb added a commit to C-Saunders/node-deep-equal that referenced this issue Dec 1, 2019
@ljharb ljharb closed this as completed in 47eb288 Dec 1, 2019
ljharb added a commit that referenced this issue Dec 1, 2019
…ssert

Merge pull request #52 from C-Saunders/map_value_equality

Fixes #54. Fixes #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants