fixed prototype comparison #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added RegExp comparison
removed test with Object.create
|
@vruivo I found a better alternative here: https://github.com/zubuzon/kewlr. Seems to support this |
|
@vruivo if you can resurrect this repository and check the "allow edits" box, we can get this in. |
|
Added a variant of this RegExp fix, and the tests, in b8c179c. |
ljharb
added
the
needs "allow edits"
This comment has been minimized.
This comment has been minimized.
ljharb
added a commit
that referenced
this pull request
Dec 4, 2019
|
Resolved in 1eac46b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added RegExp comparison and some tests