Not all Errors are equal. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RusinovAnton
approved these changes
Apr 26, 2017
ljharb
requested changes
Aug 1, 2019
index.js
Outdated
| @@ -40,6 +40,10 @@ function isBuffer (x) { | |||
| return true; | |||
| } | |||
|
|
|||
| function isError (x) { | |||
| return x instanceof Error; | |||
There was a problem hiding this comment.
The main issue is that this won’t work across realms, and it will fail on an Error that has had its [[Prototype]] changed.
index.js
Outdated
| @@ -66,6 +70,14 @@ function objEquiv(a, b, opts) { | |||
| } | |||
| return true; | |||
| } | |||
| if (isError(a)) { | |||
| if (!isError(b)) { | |||
There was a problem hiding this comment.
this won’t work right if the first is not an error but the second is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #47