Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - Add specific error message if no SpanExporter is defined #9

Closed
aaronweissler opened this issue May 19, 2022 · 1 comment · Fixed by #7
Closed

[Feature] - Add specific error message if no SpanExporter is defined #9

aaronweissler opened this issue May 19, 2022 · 1 comment · Fixed by #7
Assignees
@aaronweissler
Labels
area/eum-server

Comments

@aaronweissler
Copy link
Member

Is your feature request related to a problem? Please describe.
When no SpanExporter was created due to not enabling it in the configuration, a null Exception is thrown at TraceController:58. I think an error message that explains that the problem is that no SpanExporter was activated in the configuration would be helpful.

Depending on when inspectIT/inspectit-ocelot#1427 and #1 are resolved, it would be easier to add this in the new repo right away.
@heiko-holz
Copy link
Contributor

heiko-holz commented May 19, 2022 •
edited
Loading

I think catching the case that no SpanExporter is defined/enabled would also be appropriate, i.e., should we allow that no SpanExporter is enabled and just throw a warning?

@aaronweissler aaronweissler self-assigned this May 30, 2022
@aaronweissler aaronweissler mentioned this issue May 30, 2022
Merged
@aaronweissler aaronweissler transferred this issue from inspectIT/inspectit-ocelot May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronweissler aaronweissler

Labels
area/eum-server
Projects
None yet
Milestone
No milestone
2 participants
@heiko-holz @aaronweissler