Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EUM-server to separate repo #1

Merged
merged 9 commits into from
May 30, 2022
Merged

Conversation

aaronweissler
Copy link
Member

@aaronweissler aaronweissler commented May 9, 2022

This change is Reviewable

@aaronweissler aaronweissler changed the title Move EUM-server to separate repo Move eum-server to separate repo May 9, 2022
@aaronweissler aaronweissler changed the title Move eum-server to separate repo Move EUM-server to separate repo May 9, 2022
Copy link
Member Author

@aaronweissler aaronweissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 114 files reviewed, 1 unresolved discussion

a discussion (no related file):
Needs changes relating to EUM-server from inspectIT/inspectit-ocelot#1375 as well


Copy link
Member Author

@aaronweissler aaronweissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 116 files reviewed, all discussions resolved

a discussion (no related file):

Previously, aaronweissler wrote…

Needs changes relating to EUM-server from inspectIT/inspectit-ocelot#1375 as well

Changes are added now.


Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 105 of 114 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)


LICENSE line 189 at r2 (raw file):

      identification within third-party archives.

   Copyright 2019 Novatec Consulting GmbH

is 2019 correct? or rather 2022?
Is this set automatically or manually?

Copy link
Member Author

@aaronweissler aaronweissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)


LICENSE line 189 at r2 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

is 2019 correct? or rather 2022?
Is this set automatically or manually?

It was just set to "Copyright [yyyy] [name of copyright owner]" probably automatically by GitHub before. I then manually added the year and name.
I'm not sure which year would be more appropriate. I simply copied the info from the inspectit-ocelot repo's license

@heiko-holz heiko-holz merged commit 10ee02d into inspectIT:main May 30, 2022
heiko-holz pushed a commit that referenced this pull request Dec 16, 2022
feat(authentication): renamed config-directory to token-directory and…
heiko-holz pushed a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants