Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #16: [Feature] - Add support for OTLP exporters (tracing and metrics) #19

Merged
merged 11 commits into from
Jan 5, 2023

Conversation

heiko-holz
Copy link
Contributor

@heiko-holz heiko-holz commented Nov 30, 2022

Closes #16 #12


This change is Reviewable

Copy link
Contributor

@danipaniii danipaniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, it is readable, unfortunately I cannot give much advice about improvements. However all the test cases that implement the ExporterIntTestBaseWithOtelCollector are getting ignored. It could be that this is just a local issue for me, because at first they couldn't get executed because of missing docker-machine installation, after installing docker-machine they got ignored because of missing configuration.

Reviewed 14 of 29 files at r1, 9 of 10 files at r2, all commit messages.
Reviewable status: 23 of 31 files reviewed, all discussions resolved (waiting on @quandor)

@heiko-holz heiko-holz force-pushed the features/feat-16-otlp-exporter branch from b57b315 to 86c7d6d Compare January 2, 2023 07:19
@heiko-holz
Copy link
Contributor Author

I just ran the tests locally and they work fine.

I've also just rebased this feature branch to the main branch

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 29 files at r1, 1 of 10 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @heiko-holz)

@heiko-holz heiko-holz merged commit 054ad0a into inspectIT:main Jan 5, 2023
@heiko-holz heiko-holz deleted the features/feat-16-otlp-exporter branch January 5, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Add support for OTLP exporters (tracing and metrics)
4 participants