-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #16: [Feature] - Add support for OTLP exporters (tracing and metrics) #19
Closes #16: [Feature] - Add support for OTLP exporters (tracing and metrics) #19
Conversation
d42058d
to
b57b315
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, it is readable, unfortunately I cannot give much advice about improvements. However all the test cases that implement the ExporterIntTestBaseWithOtelCollector are getting ignored. It could be that this is just a local issue for me, because at first they couldn't get executed because of missing docker-machine installation, after installing docker-machine they got ignored because of missing configuration.
Reviewed 14 of 29 files at r1, 9 of 10 files at r2, all commit messages.
Reviewable status: 23 of 31 files reviewed, all discussions resolved (waiting on @quandor)
b57b315
to
86c7d6d
Compare
I just ran the tests locally and they work fine. I've also just rebased this feature branch to the main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 29 files at r1, 1 of 10 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @heiko-holz)
Closes #16 #12
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)