Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explains token file format in README #26

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Explains token file format in README #26

merged 2 commits into from
Jan 25, 2023

Conversation

quandor
Copy link
Contributor

@quandor quandor commented Jan 24, 2023

This change is Reviewable

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @quandor)


README.md line 285 at r1 (raw file):

The format for the token files is as follows:
```yaml
  # Allows grouping of tokens. E.g. you can document which application, person, organization, etc. knows about this token. It has no influence on security.

How can I understand the "grouping"?
I can't add multiple token to the same group, right?

Copy link
Contributor Author

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @heiko-holz)


README.md line 285 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

How can I understand the "grouping"?
I can't add multiple token to the same group, right?

You are right. grouping is a misleading. I rephrased that sentence.

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @quandor)


README.md line 285 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

You are right. grouping is a misleading. I rephrased that sentence.

Perfect, thanks!

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @quandor)

@heiko-holz heiko-holz merged commit 2ce5c6f into inspectIT:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants