Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #28 Changelog Config fails to get fetched #29

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Closes #28 Changelog Config fails to get fetched #29

merged 4 commits into from
Feb 10, 2023

Conversation

danipaniii
Copy link
Contributor

@danipaniii danipaniii commented Jan 30, 2023

Closes #28
With this PR, the config file for the changelog gets fetched and the changelog gets generated properly.


This change is Reviewable

@danipaniii danipaniii added the fix label Jan 30, 2023
Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @danipaniii)


.github/workflows/eumserver-release-config.json line 4 at r1 (raw file):

    "categories": [
        {
            "title": "## 🛠 Breaking Changs",

Let's try to be consistent in the changelog of the agent and the eum-server.

We suggest the following:

  • 🛠 Breaking Changes
  • 🚀 Implemented Enhancements
  • 🐛 Bugfixes
  • 🧪 Tests
  • Other Changes

I don't care whether the icon before or after the text.

It would be great if you can commit the same changes to the PR https://reviewable.io/reviews/inspectit/inspectit-ocelot/1516#-NN6GHcU-0YyL4pKL0jl


.github/workflows/eumserver-release-config.json line 13 at r1 (raw file):

        {
            "title": "## 🐛 Fixes",
            "labels": ["fix"]

Add "bug" as a label as well, as the issues will be labeled "bug" (and rarely "fix")


.github/workflows/eumserver_release.yml line 15 at r1 (raw file):

      name: Build and release EUM Server
      runs-on: ubuntu-latest
      needs: [test_eum_server] #test

do we need this comment here?
What does it mean?

Copy link
Contributor Author

@danipaniii danipaniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @heiko-holz)


.github/workflows/eumserver-release-config.json line 4 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

Let's try to be consistent in the changelog of the agent and the eum-server.

We suggest the following:

  • 🛠 Breaking Changes
  • 🚀 Implemented Enhancements
  • 🐛 Bugfixes
  • 🧪 Tests
  • Other Changes

I don't care whether the icon before or after the text.

It would be great if you can commit the same changes to the PR https://reviewable.io/reviews/inspectit/inspectit-ocelot/1516#-NN6GHcU-0YyL4pKL0jl

Done.


.github/workflows/eumserver-release-config.json line 13 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

Add "bug" as a label as well, as the issues will be labeled "bug" (and rarely "fix")

Done.


.github/workflows/eumserver_release.yml line 15 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

do we need this comment here?
What does it mean?

I must have overlooked that comment. It is not needed and I removed it.

@danipaniii
Copy link
Contributor Author

Also I believe it is important to mention, that in the changelog just the PRs tagged with at least one of the mentioned labels in the changelog config will be displayed in the changelog.

Same goes for the PR: inspectIT/inspectit-ocelot#1516

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danipaniii)

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danipaniii)

@heiko-holz heiko-holz merged commit 98172f1 into inspectIT:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Changelog Config fails to get fetched
2 participants