Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate exporter registration with OpenTelemetry and opentelemetry-opencensus-shim #1269

Closed
heiko-holz opened this issue Jan 11, 2022 · 1 comment · Fixed by #1431
Closed

Integrate exporter registration with OpenTelemetry and opentelemetry-opencensus-shim #1269

heiko-holz opened this issue Jan 11, 2022 · 1 comment · Fixed by #1431
Assignees
@heiko-holz
Labels
area/agent
Milestone
v1.15.0

Comments

@heiko-holz
Copy link
Contributor

Develop and integrate a concept for the exporter registration for traces for the JaegerThriftSpanExporter and for metrics for the Prometheus exporter.

Instead of rebuilding SdkMeterProvider and OpenTelemetrySdk entirely when the configuration of any traces or metrics exporter changes, we want to dynamically register and unregister each exporter service individually, without the need of restarting all other services
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 11, 2022
inspectIT#1269: Integrated the concept of an IOpenTelemetryController…
37bdc0a 
… that handles the registration and unregister of individual traces and metrics exporter services. Fixed JaegerExporterService, PrometheusExporterService, ZipkinExporterService to work with inspectIT Ocelot. Adjusted build.gradle in the core package and added a SpringTestBase.yml configuration to speed up tests in the core module (as the OTEL implementation of the Prometheus server needs ~10 seconds to shut down).
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 13, 2022
inspectIT#1269: Changed OpenTelemetryControllerImpl to not rebuild th…
4b20a8b 
…e SdkTracerProvider when individual trace exporter services change. For this, the DynamicMultiSpanExporter and DynamicSampler have been implemented that can be updated while OpenTelemetry is running. The DynamicallyActivatableTraceExporterService now expose the spanExporter instead of the spanProcessor.
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 13, 2022
inspectIT#1269: Added tests to test tracing configuration in OpenTele…
108cb31 
…metryControllerImpl
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 13, 2022
inspectIT#1269: Fixed initialization of OpenTelemetry in Log4J2TraceI…
e4c3fd3 
…dAutoInjectorTest
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 13, 2022
inspectIT#1269: Added tests to test metrics (meter provider) configur…
7f20156 
…ation in OpenTelemetryControllerImpl
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 13, 2022
inspectIT#1269: Moved DynamicMultiSpanExporter
ffe5796
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Removed OpenCensusAgentMetricsExporterSettings.java a…
1ed7744 
…nd OpenCensusAgentTraceExporterSettings.java and updated related files
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Ad: Removed OpenCensusAgentMetricsExporterSettings.ja…
2f408ac 
…va and OpenCensusAgentTraceExporterSettings.java and updated related files
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Added new properties to TracingSettings (considering …
0626326 
…batch span exporting)
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Removed the serviceName property from JaegerExporterS…
4d0ad54 
…ettings, ZipkinExporterSettings, LoggingTraceExporterSettings, and LoggingMetricsExporterSettings, and updated related documentation.
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Removed the SpringTestBase.yml and moved the properti…
f07db85 
…es to SpringTestBase.java instead.
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Fixed InfluxExporterServiceIntTest
8a826dc
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Minor refactoring (removed unnecessary logs, added Te…
6e555bd 
…stPropertySource to tracing exporter tests)
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 17, 2022
inspectIT#1269: Slimmed down OpenTelemetryControllerImpl
0099124
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 18, 2022
inspectIT#1269: Replaced calls to OpenCensusUtils#flushSpanExporter w…
0fdac4b 
…ith Instances#openTelemetryController#flush()
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 18, 2022
inspectIT#1269: Renamed OtlpTraceExporterService to OtlpGrpcTraceExpo…
8ff8bd6 
…rterService and adjusted related classes and yml
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 18, 2022
inspectIT#1269: Fixed OtlpGrpcTraceExporterService to use "otlGrpc" i…
0a010bc 
…nstead of "otlp-grpc", which led to exceptions
@heiko-holz heiko-holz self-assigned this Jan 24, 2022
@heiko-holz heiko-holz added this to the v1.15.0 milestone Feb 1, 2022
@heiko-holz
Copy link
Contributor Author

2022-01-11-ticket-1269-1279-otel-exporters-otel-upgrade-changenotes.pdf

@mariusoe mariusoe mentioned this issue May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heiko-holz heiko-holz

Labels
area/agent
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging a pull request may close this issue.

Closes #1297 - Use OpenTelemetry as OpenCensus implementation inspectIT/inspectit-ocelot
1 participant
@heiko-holz