Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IB-536 remove plank #14

Merged

Conversation

VitalyT-Inspera
Copy link

Remove validation of license

Tested locally with updated package on grading-frontend - no plank:
image

@VitalyT-Inspera VitalyT-Inspera self-assigned this Jun 5, 2024
@gmcatalin
Copy link
Collaborator

Don't think we can merge this. We would need a license to get rid of that watermark.

@VitalyT-Inspera
Copy link
Author

Don't think we can merge this. We would need a license to get rid of that watermark.

It was discussed with @jl-inspera and Raj, they insisted on this solution. The main idea is that the Licence of CKEditor allows modifying the source code for it`s usage

Copy link
Collaborator

@gmcatalin gmcatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is ok but it's not on me to decide.

@VitalyT-Inspera VitalyT-Inspera merged commit f711a54 into IB-536_update_to_latest2 Jun 11, 2024
@gmcatalin gmcatalin deleted the IB-536_update_to_latest2_no_plank branch June 11, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants