issue-112, k8s resource events for Zookeeper resource is implemented #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RostislavPorohnya
requested review from
DoodgeMatvey,
ribaraka and
testisnullus
RostislavPorohnya
force-pushed
the
issue-112
branch
from
646ddff
to
0a5013c
Compare
ribaraka
reviewed
Mar 13, 2023
Comment on lines
40
to
41
| # twoFactorDelete: | ||
| # - email: "rostyslp@netapp.com" | ||
| twoFactorDelete: | ||
| - email: "rostyslp@netapp.com" |
There was a problem hiding this comment.
Commented
RostislavPorohnya
force-pushed
the
issue-112
branch
from
0a5013c
to
97944f4
Compare
ribaraka
approved these changes
Mar 13, 2023
DoodgeMatvey
requested changes
Mar 13, 2023
| @@ -115,13 +114,29 @@ func (r *ZookeeperReconciler) handleCreateCluster( | |||
| zook.Status.ID, err = r.API.CreateCluster(instaclustr.ZookeeperEndpoint, zook.Spec.ToInstAPI()) | |||
| if err != nil { | |||
| l.Error(err, "Cannot create zookeeper cluster", "spec", zook.Spec) | |||
| r.EventRecorder.Eventf( | |||
| zook, models.Warning, models.CreationFailed, | |||
| "Cluster creation on the Instaclustr cloud is failed. Reason: %v", | |||
There was a problem hiding this comment.
You have different event messages for create cases. Standardize them and bring them to one form
RostislavPorohnya
force-pushed
the
issue-112
branch
from
97944f4
to
e9064c4
Compare
DoodgeMatvey
approved these changes
Mar 13, 2023
taaraora
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #352